PHOENIX-5215 Migrate from HTrace to OpenTelemetry tracing#2394
PHOENIX-5215 Migrate from HTrace to OpenTelemetry tracing#2394xavifeds8 wants to merge 1 commit intoapache:masterfrom
Conversation
xavifeds8
changed the title
xavifeds8
force-pushed
the
feature/opentel/phase1-clean
branch
2 times, most recently
from
8ae70d1 to
d4fd4bf
Compare
xavifeds8
changed the title
xavifeds8
force-pushed
the
feature/opentel/phase1-clean
branch
from
d4fd4bf to
433e477
Compare
|
@stoty , @virajjasani
setup gist: <script src="https://gist.github.com/xavifeds8/b7e8bcb7707844a1e106686559f04ccd.js"></script> Please tell me if the approach seems good to you or you see any issues in the approach. |
|
Nice work @xavifeds8! The approach seems good. IIUC, this PR only moves from HTrace to OpenTelemetry and in the next set of PRs, you would add more spans? Could you fix spotless issues and ASF license warnings reported in the latest build? |
Hey @virajjasani thanks for the reviewing the approach. Also, I wanted to ask about how to handle upcoming commits. Should I continue pushing them to the same PR that i have raised? I’m concerned that might make the review process a bit overwhelming. Alternatively, would it be better to create a feature branch and i will raise PRs there? What would you suggest? |
2 participants
This PR replaces the deprecated Apache HTrace tracing system with OpenTelemetry, following the same proven pattern that Apache HBase adopted in HBASE-22120. Phoenix now depends only on the OpenTelemetry API at compile time (scope=provided), with the SDK provided at runtime by the OpenTelemetry Java Agent. When no agent is attached, all tracing calls are no-ops with zero overhead.